-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save load requests #29
Conversation
I added two config options, collections path and recent requests limit and its defaults
I also added a TODO to fix atom.config to be passed to the view, now It doesn't work
I also added an empty spec file for persist
With events we separate logic in differents parts of our module. For now the loading button
I fixed the method highlighting when loading requests, I think we're ready to merge, I'll try to fix the Travis environment this week. @ddavison Please let me know if you find anything, otherwise we could merge and create a new version. :-) |
I've spent some time on the Travis issue, but I haven't found how to fix It yet. I'll vote for merging the PR and create the new GIF for the Readme, I can do It if you're ok with It @ddavison. |
yea, sorry - i just got a new computer, so still customizing it, and getting all my workspaces back up ;) |
i'd also like to implement #30 in this branch |
going to push the new version now |
pushed as new major version. 1.0 finally :P |
Veery nice! :-D On Tue, Mar 15, 2016, 18:33 Dj notifications@github.com wrote:
|
With this functionality we can save requests (100 for now, but this will be configurable in the future). We also have a recent requests feature where the most recent requests are stored.
@ddavison Can you check if It's working for you too?
Any opinion or criticism, here I am!
Note: the Unittests are passing, but sometimes there is some kind of timeout problem with Travis CI, we might need to change this configuration.